From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
Matt Domsch <Matt_Domsch@dell.com>,
Jeff Garzik <jgarzik@pobox.com>, Jason Holmes <jholmes@psu.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make 2.6 megaraid recognize intel vendor id
Date: Wed, 19 Nov 2003 20:13:27 +0100 [thread overview]
Message-ID: <20031119191327.GA1053@mars.ravnborg.org> (raw)
In-Reply-To: <20031119131627.A12116@infradead.org>
Hi Christoph, nice rewrite.
Minor comments - which is not not specific for ypur clean-up, but maybe
worth addressing now?
> +#ifdef CONFIG_PROC_FS
> + if (adapter->controller_proc_dir_entry) {
> + remove_proc_entry("stat", adapter->controller_proc_dir_entry);
> + remove_proc_entry("config",
> + adapter->controller_proc_dir_entry);
remove_proc_entry is an empty do {} while, so the ifdef is not needed.
> +#if MEGA_HAVE_ENH_PROC
Looks like a potential CONFIG option?
> +#ifdef CONFIG_PROC_FS
> + remove_proc_entry("megaraid", &proc_root);
> +#endif
ifdef not needed.
Sam
next prev parent reply other threads:[~2003-11-19 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 17:14 Jason Holmes
2003-11-13 19:04 ` Jeff Garzik
2003-11-13 21:35 ` Matt Domsch
2003-11-19 13:16 ` Christoph Hellwig
2003-11-19 16:39 ` Jason Holmes
2003-11-19 19:13 ` Sam Ravnborg [this message]
2003-11-14 14:00 Mukker, Atul
2003-11-14 14:01 ` Jeff Garzik
2003-11-16 2:45 Tomita, Haruo
2003-11-16 2:50 ` Jeff Garzik
2003-11-16 3:12 Tomita, Haruo
2003-11-16 3:46 ` Vagn Scott
2003-11-16 4:36 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031119191327.GA1053@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Matt_Domsch@dell.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=jholmes@psu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome