Re: 2.6.0-test9-mm4 (only) and vmware

[William Lee Irwin III <wli@holomorphy.com>]

William Lee Irwin III <wli@holomorphy.com> wrote:
>>  Here it is.

On Wed, Nov 19, 2003 at 05:58:03PM -0800, Andrew Morton wrote:
> All the world's an x86 ;)
> This whole patch is getting rather large.
> ARM is doing weird stuff.

I just realized this can all be done in one line by setting the initial
value of ret to VM_FAULT_MINOR in do_no_page(). The ->nopage() methods
not updated will give off compiler warnings and since they think their
third arguments are ordinary integers, they won't update the referenced
content, and the initializer of VM_FAULT_MINOR then comes into play.


-- wli


diff -prauN mm4-2.6.0-test9-1/mm/memory.c mm4-2.6.0-test9-default-2/mm/memory.c
--- mm4-2.6.0-test9-1/mm/memory.c	2003-11-19 00:07:15.000000000 -0800
+++ mm4-2.6.0-test9-default-2/mm/memory.c	2003-11-19 18:08:49.000000000 -0800
@@ -1424,7 +1424,7 @@ do_no_page(struct mm_struct *mm, struct 
 	pte_t entry;
 	struct pte_chain *pte_chain;
 	int sequence = 0;
-	int ret;
+	int ret = VM_FAULT_MINOR;
 
 	if (!vma->vm_ops || !vma->vm_ops->nopage)
 		return do_anonymous_page(mm, vma, page_table,