From: viro@parcelfarce.linux.theplanet.co.uk
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@osdl.org>, Andrew Morton <akpm@osdl.org>,
Dipankar Sarma <dipankar@in.ibm.com>
Subject: Re: [PATCH] sysfs_remove_dir Vs dcache_readdir race fix
Date: Thu, 20 Nov 2003 18:43:22 +0000 [thread overview]
Message-ID: <20031120184322.GE24159@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20031120102525.GD1367@in.ibm.com>
On Thu, Nov 20, 2003 at 03:55:25PM +0530, Maneesh Soni wrote:
> Actually race is not directly between dcache_readdir and sysfs_remove_dir but
> it is like this
>
> cpu 0 cpu 1
> dcache_dir_open()
> --> adds the cursor dentry
>
> sysfs_remove_dir()
> --> list_del_init cursor dentry
>
> dcache_readdir()
> --> loops forever on inititalized cursor dentry.
Yes. Thanks for spotting...
> Though all these operations happen under parent's i_sem, but it is dropped
> between ->open() and ->readdir() as both are different calls.
>
> I think people will also agree that there is no need for sysfs_remove_dir()
> to modify d_subdirs list.
Agreed.
prev parent reply other threads:[~2003-11-20 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-20 5:47 Maneesh Soni
2003-11-20 5:49 ` viro
2003-11-20 5:56 ` Maneesh Soni
2003-11-20 10:25 ` Maneesh Soni
2003-11-20 15:17 ` Andrew Morton
2003-11-20 16:40 ` Dipankar Sarma
2003-11-20 18:44 ` viro
2003-11-20 18:43 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031120184322.GE24159@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®