From: Geoffrey Lee <glee@gnupilgrims.org>
To: linux-kernel@vger.kernel.org
Subject: [patch] sis comparison / assignment operator fix
Date: Mon, 24 Nov 2003 14:41:20 +0800 [thread overview]
Message-ID: <20031124064120.GA13435@anakin.wychk.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
Hi,
This fixes what seems to be an obvious = vs == bug in the init301.c
sis file.
It has
if (temp = 0xffff) return;
which should always be true, so it always returns.
- g.
--
geoff.
[-- Attachment #2: sis-init301.c.patch --]
[-- Type: text/plain, Size: 480 bytes --]
--- linux-2.6.0-test10/drivers/video/sis/init301.c.orig 2003-11-24 14:36:57.000000000 +0800
+++ linux-2.6.0-test10/drivers/video/sis/init301.c 2003-11-24 14:37:59.000000000 +0800
@@ -11712,7 +11712,7 @@ SetOEMLCDData(SiS_Private *SiS_Pr, PSIS_
}
temp = GetOEMLCDPtr(SiS_Pr,HwDeviceExtension, ROMAddr, 1);
- if(temp = 0xFFFF) return;
+ if(temp == 0xFFFF) return;
index = SiS_Pr->SiS_VBModeIDTable[ModeIdIndex]._VB_LCDHIndex;
for(i=0x14, j=0; i<=0x17; i++, j++) {
next reply other threads:[~2003-11-24 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-24 6:41 Geoffrey Lee [this message]
2003-11-24 9:06 Thomas Winischhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031124064120.GA13435@anakin.wychk.org \
--to=glee@gnupilgrims.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®