From: Balazs Scheidler <bazsi@balabit.hu>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com
Subject: [PATCH] fix for crash for invalid MP table
Date: Wed, 26 Nov 2003 09:44:51 +0100 [thread overview]
Message-ID: <20031126084451.GA538@balabit.hu> (raw)
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi,
Attached you will find a patch which changes a couple of 'panic' calls to
'printk' in the MP table parsing code. The problem is that panics so early
in the boot process cause nothing to be printed on the console, my laptop
froze immediately after printing "Uncompressing Linux..."
Changing the panics to printks solved the problem here, the kernel displays
an error message but then continues to boot. I can finally use the lapic
with this patch in place.
--
Bazsi
PGP info: KeyID 9AF8D0A9 Fingerprint CD27 CFB0 802C 0944 9CFD 804E C82C 8EB1
[-- Attachment #2: printk-insteadofpanic.diff --]
[-- Type: text/plain, Size: 716 bytes --]
--- linux-2.6.0-test9/arch/i386/kernel/mpparse.c Wed Nov 26 09:36:27 2003
+++ linux-2.6.0-test9/arch/i386/kernel/mpparse.c Wed Nov 26 09:31:49 2003
@@ -361,7 +361,7 @@
unsigned char *mpt=((unsigned char *)mpc)+count;
if (memcmp(mpc->mpc_signature,MPC_SIGNATURE,4)) {
- panic("SMP mptable: bad signature [%c%c%c%c]!\n",
+ printk("SMP mptable: bad signature [%c%c%c%c]!\n",
mpc->mpc_signature[0],
mpc->mpc_signature[1],
mpc->mpc_signature[2],
@@ -369,7 +369,7 @@
return 0;
}
if (mpf_checksum((unsigned char *)mpc,mpc->mpc_length)) {
- panic("SMP mptable: checksum error!\n");
+ printk("SMP mptable: checksum error!\n");
return 0;
}
if (mpc->mpc_spec!=0x01 && mpc->mpc_spec!=0x04) {
reply other threads:[~2003-11-26 8:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031126084451.GA538@balabit.hu \
--to=bazsi@balabit.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®