From: Pete Zaitcev <zaitcev@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [USB] Fix connect/disconnect race
Date: Sun, 30 Nov 2003 21:03:34 -0500 [thread overview]
Message-ID: <200312010203.hB123YQr002367@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1070178780.32610.linux-kernel2news@redhat.com>
> This patch was integrated by you in 2.4 six months ago. Unfortunately
> it never got into 2.5. Without it you can end up with crashes such
> as http://bugs.debian.org/218670
> --- kernel-source-2.5/drivers/usb/core/hub.c 28 Sep 2003 04:44:16 -0000 1.1.1.15
> +++ kernel-source-2.5/drivers/usb/core/hub.c 30 Nov 2003 07:44:40 -0000
> break;
> }
>
> - hub->children[port] = dev;
> dev->state = USB_STATE_POWERED;
>[...]
> /* Run it through the hoops (find a driver, etc) */
> - if (!usb_new_device(dev, &hub->dev))
> + if (!usb_new_device(dev, &hub->dev)) {
> + hub->children[port] = dev;
> goto done;
> + }
I'm surprised you need it. The updated usbfs is supposed
to be immune. This is probably the reason it wasn't ported.
-- Pete
next parent reply other threads:[~2003-12-01 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1070178780.32610.linux-kernel2news@redhat.com>
2003-12-01 2:03 ` Pete Zaitcev [this message]
2003-12-01 7:16 ` Herbert Xu
2003-11-30 7:48 Herbert Xu
2003-12-10 1:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312010203.hB123YQr002367@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome