From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263402AbTLAHCH (ORCPT ); Mon, 1 Dec 2003 02:02:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263439AbTLAHCH (ORCPT ); Mon, 1 Dec 2003 02:02:07 -0500 Received: from sv1.valinux.co.jp ([210.128.90.2]:43702 "EHLO sv1.valinux.co.jp") by vger.kernel.org with ESMTP id S263402AbTLAHCE (ORCPT ); Mon, 1 Dec 2003 02:02:04 -0500 Date: Mon, 01 Dec 2003 16:02:01 +0900 From: IWAMOTO Toshihiro To: Badari Pulavarty Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.6.0-test10 O_DIRECT memory leak fix In-Reply-To: <200311251449.50397.pbadari@us.ibm.com> References: <200311251449.50397.pbadari@us.ibm.com> User-Agent: Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Message-Id: <20031201070201.A4D667007A@sv1.valinux.co.jp> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 25 Nov 2003 14:49:50 -0800, Badari Pulavarty wrote: > > [1 ] > Hi Andrew, > > I found the problem with O_DIRECT memory leak. > > The problem is, when we are doing DIO read and crossed the end of file - > we don't release referencess on all the pages we got from get_user_pages(). > (since it is a sucess case). > > The fix is to call dio_cleanup() even for sucess cases. Can you please > review this ? I tested the patch with fsstress and there are no memory leak > problems now. > > Thanks, > Badari > [2 dioleak.patch ] I've tested this patch with linux-2.6.0-test11 (plus my memory hotplug patch) on the machine I observed the memory leak. The leak seems to be fixed. Thanks. -- IWAMOTO Toshihiro