On Tue, 02 Dec 2003 14:20:15 +1100 Keith Owens wrote: >Your mailer wrapped the lines. I include the patch as a plain text attachment this time; I hope as you are not LT this doens't matter :) > Only test CONFIG_ISAPNP || CONFIG_ISAPNP_MODULE, not MODULE. > CONFIG_foo_MODULE can only be defined when MODULE is defined. > > #if defined(CONFIG_ISAPNP) || defined(CONFIG_ISAPNP_MODULE) I don't think so; from a brief look trhough Configure and Makefile, this only happens when CONFIG_ISAPNP is declared as a dependency of the driver in question. In this case it is optional so we have to check manually.