From: Michal Rokos <m.rokos@sh.cvut.cz>
To: hirofumi@mail.parknet.co.jp
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.0-test11] VFAT fix for UTF-8 and trailing dots
Date: Sat, 6 Dec 2003 09:55:39 +0100 [thread overview]
Message-ID: <20031206085539.GA3134@nightmare.sh.cvut.cz> (raw)
Hello all,
there is one problem with vfat when UTF-8 option is on...
The problem is: even if vfat_striptail_len() counts len of name without
trailing dots and sets len to the correct value, utf8_mbstowcs() doesn't
care about len and takes whole name.
So dirs and files with dots can be created on vfat fs and that will
cause some problems as you know :)
This patch just shortens outlen to the correct value - nothing else.
Compiled, tested.
Please concider the inclusion.
Thank you.
Michal
--- linux-2.6.0-test11/fs/vfat/namei.c.old 2003-11-26 21:44:34.000000000 +0100
+++ linux-2.6.0-test11/fs/vfat/namei.c 2003-12-06 09:34:44.000000000 +0100
@@ -573,13 +573,18 @@ xlate_to_uni(const unsigned char *name,
int charlen;
if (utf8) {
+ int name_len = strlen(name);
+
*outlen = utf8_mbstowcs((wchar_t *)outname, name, PAGE_SIZE);
- if (name[len-1] == '.')
- *outlen-=2;
+
+ /*
+ * We stripped '.'s before and set len appropriately,
+ * but utf8_mbstowcs doesn't care about len
+ */
+ *outlen -= (name_len-len);
+
op = &outname[*outlen * sizeof(wchar_t)];
} else {
- if (name[len-1] == '.')
- len--;
if (nls) {
for (i = 0, ip = name, op = outname, *outlen = 0;
i < len && *outlen <= 260; *outlen += 1)
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Michal Rokos Czech Technical University, Prague
e-mail: m.rokos@sh.cvut.cz icq: 36118339 jabber: majkl@jabber.cz
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2003-12-06 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-06 8:55 Michal Rokos [this message]
2003-12-06 15:52 ` OGAWA Hirofumi
2003-12-06 19:29 ` Michal Rokos
2003-12-06 21:02 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031206085539.GA3134@nightmare.sh.cvut.cz \
--to=m.rokos@sh.cvut.cz \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®