From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265286AbTLHBiF (ORCPT ); Sun, 7 Dec 2003 20:38:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265275AbTLHBiF (ORCPT ); Sun, 7 Dec 2003 20:38:05 -0500 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:45758 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S265273AbTLHBiA (ORCPT ); Sun, 7 Dec 2003 20:38:00 -0500 From: Bartlomiej Zolnierkiewicz To: Peter Chubb Subject: Re: Can't disable IDE DMA on 2.6.0-test9 (patch) Date: Mon, 8 Dec 2003 02:39:58 +0100 User-Agent: KMail/1.5.4 Cc: akpm@osdl.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <16317.18623.912339.111750@wombat.disy.cse.unsw.edu.au> In-Reply-To: <16317.18623.912339.111750@wombat.disy.cse.unsw.edu.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312080239.58602.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Friday 21 of November 2003 00:05, Peter Chubb wrote: > Hi Folks, Hi, > If you try to disable IDE DMA from Kconfig, you'll end up with an > undefined symbol, ide_hwif_setup_dma(). > > The attached rather ugly patch fixes the problem by defining a dummy > function. Not exactly. Disable IDE DMA and enable support for every PCI chipset. Now try to compile... welcome to compile time hell :-). To do this properly you have to fix almost every PCI chipset driver (by adding many CONFIG_BLK_DEV_IDEDMA_PCI #ifdefs). --bart > ===== setup-pci.c 1.19 vs edited ===== > --- 1.19/drivers/ide/setup-pci.c Sat Oct 18 01:22:22 2003 > +++ edited/setup-pci.c Wed Nov 19 13:52:25 2003 > @@ -474,6 +474,11 @@ > * state > */ > > +#ifndef CONFIG_BLK_DEV_IDEDMA_PCI > +static void ide_hwif_setup_dma(struct pci_dev *dev, ide_pci_device_t *d, > ide_hwif_t *hwif) +{ > +} > +#else > static void ide_hwif_setup_dma(struct pci_dev *dev, ide_pci_device_t *d, > ide_hwif_t *hwif) { > u16 pcicmd; > @@ -516,6 +521,7 @@ > } > } > } > +#endif /* CONFIG_BLK_DEV_IDEDMA_PCI*/ > > /** > * ide_setup_pci_controller - set up IDE PCI