From: viro@parcelfarce.linux.theplanet.co.uk
To: Domen Puncer <domen@coderock.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4.23, 2.6.0-test11] fix d_type in readdir in isofs
Date: Tue, 9 Dec 2003 10:09:59 +0000 [thread overview]
Message-ID: <20031209100959.GB4176@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200312091047.33015.domen@coderock.org>
On Tue, Dec 09, 2003 at 10:47:32AM +0100, Domen Puncer wrote:
> Hi!
>
> Played with scandir, and noticed iso9660's files d_type is always 0,
> so here's a fix.
No, it isn't. DT_UNKNOWN is "I don't know; make no assumptions".
DT_REG is "regular file". Returning it when object in question is
e.g. a symlink is wrong.
next prev parent reply other threads:[~2003-12-09 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 9:47 Domen Puncer
2003-12-09 10:09 ` viro [this message]
2003-12-09 13:45 ` Domen Puncer
2003-12-09 16:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031209100959.GB4176@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®