From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: Greg KH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sensors <sensors@Stimpy.netroedge.com>
Subject: Re: [PATCH 2.6] sensors chip updates (3 of 4)
Date: Mon, 15 Dec 2003 23:03:33 -0500 [thread overview]
Message-ID: <20031216040333.GD1658@earth.solarsys.private> (raw)
In-Reply-To: <20031216035219.GA1658@earth.solarsys.private>
This patch is from the lm_sensors project CVS, from this revision:
1.44 (mds) remove initialization of limits by driver
It is better to set these limits by a combination of /etc/sensors.conf
and 'sensors -s'; "mechanism not policy."
--- linux-2.6.0-test11-gkh/drivers/i2c/chips/lm75.c 2003-12-14 13:53:50.000000000 -0500
+++ linux-2.6.0-test11-mmh/drivers/i2c/chips/lm75.c 2003-12-14 17:52:49.000000000 -0500
@@ -51,10 +51,6 @@
#define TEMP_FROM_REG(val) ((((val & 0x7fff) >> 7) * 5) | ((val & 0x8000)?-256:0))
#define TEMP_TO_REG(val) (SENSORS_LIMIT((val<0?(0x200+((val)/5))<<7:(((val) + 2) / 5) << 7),0,0xffff))
-/* Initial values */
-#define LM75_INIT_TEMP_OS 600
-#define LM75_INIT_TEMP_HYST 500
-
/* Each client has this additional data */
struct lm75_data {
struct semaphore update_lock;
@@ -258,10 +254,6 @@
static void lm75_init_client(struct i2c_client *client)
{
/* Initialize the LM75 chip */
- lm75_write_value(client, LM75_REG_TEMP_OS,
- TEMP_TO_REG(LM75_INIT_TEMP_OS));
- lm75_write_value(client, LM75_REG_TEMP_HYST,
- TEMP_TO_REG(LM75_INIT_TEMP_HYST));
lm75_write_value(client, LM75_REG_CONF, 0);
}
--
Mark M. Hoffman
mhoffman@lightlink.com
next prev parent reply other threads:[~2003-12-16 4:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-16 3:52 [PATCH 2.6] sensors chip updates Mark M. Hoffman
2003-12-16 4:02 ` [PATCH 2.6] sensors chip updates (1 of 4) Mark M. Hoffman
2003-12-16 4:02 ` [PATCH 2.6] sensors chip updates (2 " Mark M. Hoffman
2003-12-16 4:03 ` Mark M. Hoffman [this message]
2003-12-16 4:04 ` [PATCH 2.6] sensors chip updates (4 " Mark M. Hoffman
2003-12-16 21:56 ` [PATCH 2.6] sensors chip updates Jean Delvare
2003-12-20 11:41 ` nforce2 one card per irq only Bob
2003-12-18 0:04 ` [PATCH 2.6] sensors chip updates Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031216040333.GD1658@earth.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®