From: viro@parcelfarce.linux.theplanet.co.uk
To: Thomas Molina <tmolina@cablespeed.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Is Rational rational?
Date: Tue, 16 Dec 2003 04:48:27 +0000 [thread overview]
Message-ID: <20031216044827.GO4176@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0312152105550.5094@localhost.localdomain>
On Mon, Dec 15, 2003 at 09:59:58PM -0500, Thomas Molina wrote:
> static inline int may_delete(struct inode *dir,struct dentry *victim, int isdir)
> {
> int error;
> - if (!victim->d_inode || victim->d_parent->d_inode != dir)
> + if (!victim->d_inode)
> return -ENOENT;
+ BUG_ON(victim->d_parent->d_inode != dir);
HAND.
> I'm not really competent to evaluate this proposesd patch, but it
> certainly makes me nervous. Their comment on this also bothers me:
> "Rational Software believes that the check that is removed by this patch
> is one that should never fail for any properly operating filesystem. "
Precisely. It does fail for their code, though. Obvious conclusions are left
as an exercise to readers.
prev parent reply other threads:[~2003-12-16 4:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-16 2:59 Thomas Molina
2003-12-16 3:22 ` Linus Torvalds
2003-12-16 4:48 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031216044827.GO4176@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tmolina@cablespeed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome