From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, dahinds@users.sourceforge.net
Subject: [2.4 patch] fix two pcmcia/cardbus.c compile warnings
Date: Fri, 19 Dec 2003 23:31:18 +0100 [thread overview]
Message-ID: <20031219223118.GX12750@fs.tum.de> (raw)
I got the following compile warnings in 2.4.24-pre1:
<-- snip -->
...
gcc -D__KERNEL__ -I/tmp/linux-2.4.24-pre1/include -Wall
-Wstrict-prototypes -Wn\
o-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer
-pipe -mp\
referred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix include
-DKBUILD\
_BASENAME=cardbus -c -o cardbus.o cardbus.c
cardbus.c: In function `cb_scan_slot':
...
cardbus.c:226: warning: unused variable `bus'
cardbus.c: In function `program_bridge':
cardbus.c:405: warning: control reaches end of non-void function
...
<-- snip -->
The patch below does the following:
- remove the unused variable
- make the function without return void (the only caller doesn't check
the return value)
Please apply
Adrian
--- linux-2.4.24-pre1/drivers/pcmcia/cardbus.c.old 2003-12-19 21:35:52.000000000 +0100
+++ linux-2.4.24-pre1/drivers/pcmcia/cardbus.c 2003-12-19 21:36:49.000000000 +0100
@@ -223,7 +223,6 @@
struct pci_dev *cb_scan_slot(struct pci_dev *temp, struct list_head *list)
{
- struct pci_bus *bus = temp->bus;
struct pci_dev *dev;
struct pci_dev *first_dev = NULL;
int func = 0;
@@ -369,7 +368,7 @@
return max;
}
-static int program_bridge(struct pci_dev *bridge)
+static void program_bridge(struct pci_dev *bridge)
{
u32 l;
reply other threads:[~2003-12-19 22:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031219223118.GX12750@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=dahinds@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®