mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-hotplug-devel@lists.sourceforge.net
Subject: [PATCH] fix sysfs oops  [1/4]
Date: Mon, 22 Dec 2003 16:24:39 -0800	[thread overview]
Message-ID: <20031223002439.GB4805@kroah.com> (raw)
In-Reply-To: <20031223002126.GA4805@kroah.com>

This fixes an oops when a kobject is unregistered before it's child is.
The usb-serial devices show this bug very easily (yank out a device
while its port is opened...)

Patch was originally written by Mike Gorse <mgorse@mgorse.dhs.org>


diff -Nru a/fs/sysfs/dir.c b/fs/sysfs/dir.c
--- a/fs/sysfs/dir.c	Mon Dec 22 16:02:07 2003
+++ b/fs/sysfs/dir.c	Mon Dec 22 16:02:07 2003
@@ -83,7 +83,8 @@
 	struct dentry * parent = dget(d->d_parent);
 	down(&parent->d_inode->i_sem);
 	d_delete(d);
-	simple_rmdir(parent->d_inode,d);
+	if (d->d_inode)
+		simple_rmdir(parent->d_inode,d);
 
 	pr_debug(" o %s removing done (%d)\n",d->d_name.name,
 		 atomic_read(&d->d_count));

  reply	other threads:[~2003-12-23  0:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-23  0:21 [PATCH] some sysfs patches for 2.6.0 [0/4] Greg KH
2003-12-23  0:24 ` Greg KH [this message]
2003-12-23  0:26   ` [PATCH] add sysfs mem device support [2/4] Greg KH
2003-12-23  0:28     ` [PATCH] add sysfs misc device support [3/4] Greg KH
2003-12-23  0:28       ` [PATCH] add sysfs vc device support [4/4] Greg KH
2003-12-23 13:17         ` Christoph Hellwig
2003-12-23  0:29       ` [PATCH] add sysfs misc device support [3/4] Greg KH
2003-12-23 13:16       ` Christoph Hellwig
2003-12-23 13:15     ` [PATCH] add sysfs mem device support [2/4] Christoph Hellwig
2003-12-23 15:31       ` Rob Love
2003-12-23 16:07         ` Rob Love
2003-12-23 16:39         ` Christoph Hellwig
2003-12-23 17:56           ` Rob Love
2003-12-23 20:00           ` Stephan Maciej
2003-12-23 20:33             ` viro
2003-12-25 17:48           ` Andreas Jellinghaus
2003-12-25 18:45             ` Christoph Hellwig
2003-12-25 19:41               ` Martin Schlemmer
2003-12-25 20:57                 ` Martin J. Bligh
2003-12-25 22:02                   ` Martin Schlemmer
2003-12-26 16:19                 ` Christoph Hellwig
2003-12-26 16:54                   ` Tomasz Torcz
2003-12-26 20:18                     ` Martin Schlemmer
2003-12-23 18:01       ` Greg KH
2003-12-23 19:16         ` Christoph Hellwig
2003-12-23 19:19           ` Rob Love
2003-12-23 19:22             ` Christoph Hellwig
2003-12-23 19:25               ` Rob Love
2003-12-23 19:42                 ` Jeff Garzik
2003-12-23 19:45                   ` Rob Love
2003-12-23 19:24             ` viro
2003-12-23 19:28               ` Rob Love
2003-12-23 11:07 ` [PATCH] some sysfs patches for 2.6.0 [0/4] Andreas Jellinghaus
2003-12-23 23:26   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031223002439.GB4805@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®