From: Omkhar Arasaratnam <omkhar@rogers.com>
To: emoenke@gwdg.de
Cc: linux-kernel@vger.kernel.org, mbligh@aracnet.com,
trivial@rustcorp.com.au, randy@kerneljanitors.org
Subject: [PATCH] drivers/cdrom/cm206.c trivial check_region() fix
Date: Fri, 2 Jan 2004 12:25:19 -0500 [thread overview]
Message-ID: <20040102172519.GA7343@omkhar.ibm.com> (raw)
check_region() fix
--- linux-clean/drivers/cdrom/cm206.c.org 2004-01-02 12:09:49.000000000 -0500
+++ linux-clean/drivers/cdrom/cm206.c 2004-01-02 12:22:23.000000000 -0500
@@ -1389,7 +1389,7 @@
Linus says it is too dangerous to use writes for probing, so we
stick with pure reads for a while. Hope that 8 possible ranges,
- check_region, 15 bits of one port and 6 of another make things
+ request_region, 15 bits of one port and 6 of another make things
likely enough to accept the region on the first hit...
*/
int __init probe_base_port(int base)
@@ -1400,13 +1400,15 @@
if (base)
b = e = base;
for (base = b; base <= e; base += 0x10) {
- if (check_region(base, 0x10))
+ if (!request_region(base, 0x10,"cm206"))
continue;
for (i = 0; i < 3; i++)
fool = inw(base + 2); /* empty possibly uart_receive_buffer */
if ((inw(base + 6) & 0xffef) != 0x0001 || /* line_status */
- (inw(base) & 0xad00) != 0) /* data status */
+ (inw(base) & 0xad00) != 0) { /* data status */
+ release_region(base,0x10);
continue;
+ }
return (base);
}
return 0;
@@ -1444,7 +1446,6 @@
return -EIO;
}
printk(" adapter at 0x%x", cm206_base);
- request_region(cm206_base, 16, "cm206");
cd = (struct cm206_struct *) kmalloc(size, GFP_KERNEL);
if (!cd)
goto out_base;
O
reply other threads:[~2004-01-02 17:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040102172519.GA7343@omkhar.ibm.com \
--to=omkhar@rogers.com \
--cc=emoenke@gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=randy@kerneljanitors.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome