From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
len.brown@intel.com
Subject: two acpi_disable's are bad for kernel
Date: Sat, 3 Jan 2004 13:39:29 +0100 [thread overview]
Message-ID: <20040103123929.GA401@elf.ucw.cz> (raw)
Hi!
acpi_disable() is there already to disable interrupts. Its bad idea to
have two functions of same name. Please apply,
Pavel
Index: linux.new/arch/i386/kernel/dmi_scan.c
===================================================================
--- linux.new.orig/arch/i386/kernel/dmi_scan.c 2003-12-25 13:28:48.000000000 +0100
+++ linux.new/arch/i386/kernel/dmi_scan.c 2003-12-25 13:29:08.000000000 +0100
@@ -506,7 +507,7 @@
extern int acpi_disabled, acpi_force;
-static __init __attribute__((unused)) int acpi_disable(struct dmi_blacklist *d)
+static __init __attribute__((unused)) int disable_acpi(struct dmi_blacklist *d)
{
if (!acpi_force) {
printk(KERN_NOTICE "%s detected: acpi off\n",d->ident);
@@ -880,7 +881,7 @@
* Boxes that need ACPI disabled
*/
- { acpi_disable, "IBM Thinkpad", {
+ { disable_acpi, "IBM Thinkpad", {
MATCH(DMI_BOARD_VENDOR, "IBM"),
MATCH(DMI_BOARD_NAME, "2629H1G"),
NO_MATCH, NO_MATCH }},
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
reply other threads:[~2004-01-03 12:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040103123929.GA401@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®