From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266066AbUAFEEQ (ORCPT ); Mon, 5 Jan 2004 23:04:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266068AbUAFEEQ (ORCPT ); Mon, 5 Jan 2004 23:04:16 -0500 Received: from pizda.ninka.net ([216.101.162.242]:29584 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id S266066AbUAFEEM (ORCPT ); Mon, 5 Jan 2004 23:04:12 -0500 Date: Mon, 5 Jan 2004 19:58:27 -0800 From: "David S. Miller" To: Martin Diehl Cc: irda-users@lists.sourceforge.net, rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [irda-users] (irda) Badness in local_bh_enable at kernel/softirq.c:121 Message-Id: <20040105195827.0b15403f.davem@redhat.com> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.6; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Dec 2003 00:33:34 +0100 (CET) Martin Diehl wrote: > On Sat, 27 Dec 2003, Martin Diehl wrote: > > > Beware, there's another local_bh_enable issue with ircomm even with this > > patch applied. It's triggered when the ircomm-dev wasn't closed by the > > application before exiting (say kill -9 f.e.). So if you get another such > > badness warning with slightly different backtrace, chances are you also > > want to apply the "IrCOMM detach Oops" fixes from Jean's page. > > Oops, right after sending this I realized you aren't using the sirdev at > all, so in fact this is already the second case triggered from the > ircomm-shutdown path - like davem was already pointing to. > Below said patch from Jean. I'm going to add this to my tree, the patch looks perfectly fine and we might as well get this thing fixed now rather than later.