From: Paul Jackson <pj@sgi.com>
To: Joe Korty <joe.korty@ccur.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: reduce cpumask digit grouping from 8 to 4
Date: Wed, 7 Jan 2004 18:16:55 -0800 [thread overview]
Message-ID: <20040107181655.74451845.pj@sgi.com> (raw)
In-Reply-To: <20040107171142.GA11525@rudolph.ccur.com>
Joe proposed changing mask displays from 8 to 4 chars:
- u32 *wordp = (u32 *)maskp;
- int i = maskbytes/sizeof(u32) - 1;
+ u16 *wordp = (u16 *)maskp;
+ int i = maskbytes/sizeof(u16) - 1;
Please don't apply this proposed patch as it stands.
It changes the output, without touching the input side (where the kernel
parses ascii masks from userland). The in and out formats should be the
same. See the other u32 appearances in this same file, mask.c, for the
other places that would need to be changed.
And I'd like to see a bit of a consensus for such a format change,
especially, in this case, from developers of systems with NR_CPUS in the
range of 17 to 32, who would go from a single ascii hex word to a
comma-separated double word with this change. My hunch is that they
would prefer not to make this proposed format change.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
prev parent reply other threads:[~2004-01-08 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 17:11 Joe Korty
2004-01-07 19:40 ` Andrew Morton
2004-01-08 2:16 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040107181655.74451845.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome