From: Rusty Russell <rusty@rustcorp.com.au>
To: Omkhar Arasaratnam <omkhar@rogers.com>
Cc: gene.heskett@verizon.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/advansys.c check_region() fix
Date: Thu, 08 Jan 2004 10:26:05 +1100 [thread overview]
Message-ID: <20040108002255.69A532C46A@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 30 Dec 2003 08:44:33 CDT." <20031230134433.GA22187@omkhar.ibm.com>
In message <20031230134433.GA22187@omkhar.ibm.com> you write:
> Another trivial check_region() fix verified by Gene
And almost certainly wrong.
The *point* of request_region() is that you do it before any I/O to
the region.
So you can't release it before calling AscGetChipVersion().
Converting this driver is quite a bit of work, since you have to trace
down every path which uses the region and make sure it's covered. The
fact that it's formatted like an angry haiku doesn't help.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2004-01-08 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-30 13:44 Omkhar Arasaratnam
2004-01-07 23:26 ` Rusty Russell [this message]
2004-01-08 4:09 ` Gene Heskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040108002255.69A532C46A@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=gene.heskett@verizon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=omkhar@rogers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome