From: Joilnen Leite <pidhash@yahoo.com>
To: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: davem@redhat.com
Subject: about ipmr
Date: Thu, 8 Jan 2004 21:34:33 -0800 (PST) [thread overview]
Message-ID: <20040109053433.3812.qmail@web12609.mail.yahoo.com> (raw)
In-Reply-To: <200401071534.i07FY8IY032449@green.mif.pg.gda.pl>
excuse me for my english bad :) !
alloc_netdev func can return NULL and I think that is
not right to use dev pointer in this case without a
test.
so maybe it is better ? !
---------------------------------------------
--- knl_src/net/ipv4/ipmr.c 2003-11-25
16:02:59.000000000 -0300
+++ ipmr_patch.c 2004-01-08 10:21:22.000000000 -0300
@@ -205,7 +205,7 @@
dev = alloc_netdev(sizeof(struct net_device_stats),
"pimreg",
reg_vif_setup);
- if (register_netdevice(dev)) {
+ if (dev&®ister_netdevice(dev)) {
kfree(dev);
return NULL;
}
----------------------------------------------
sorry if is a dumb question and thanks for atention
pub 1024D/5139533E Joilnen Batista Leite
F565 BD0B 1A39 390D 827E 03E5 0CD4 0F20 5139 533E
__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus
next prev parent reply other threads:[~2004-01-09 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 15:34 Linux 2.4.25-pre4 Andrzej Krzysztofowicz
2004-01-09 5:34 ` Joilnen Leite [this message]
2004-01-09 6:41 ` about ipmr Raj
2004-01-09 16:29 ` James Morris
2004-01-14 0:03 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109053433.3812.qmail@web12609.mail.yahoo.com \
--to=pidhash@yahoo.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome