From: Jan Kara <jack@suse.cz>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org, Jan Kara <jack@ucw.cz>
Subject: Re: [2.4 patch] fix CONFIG_QFMT_V2 description
Date: Fri, 9 Jan 2004 14:27:31 +0100 [thread overview]
Message-ID: <20040109132731.GC28922@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20040109022742.GA1440@fs.tum.de>
> On Wed, Jan 07, 2004 at 04:11:10PM +0000, Christoph Hellwig wrote:
> > On Wed, Jan 07, 2004 at 04:59:40PM +0100, Adrian Bunk wrote:
> > > In 2,4, the CONFIG_QFMT_V2 short description talks about a
> > > "VFS v0 quota format". Is this really correct, or is the patch below
> > > that uses the "Quota format v2 support" text from 2.6 instead correct?
> >
> > I think you should ask Jan Kara instead what he prefers. This VFS v0
> > stuff is his invention. Personally I'm a little confused about the proper
> > naming, too.
>
> Jan, could you check whether the patch below is correct?
I don't have a strong opinion on this but I like the current state
slightly more. I know there's a mess that VFSv0 = quota_v2. But
currently it's at least in the state that what users (admins) see is
VFSv0 and v2 appears only in the name of kernel config options and in
the identifiers in the code. Changing VFSv0 to "v2" in kernel is no
problem but quota-tools use VFSv0 too and it's also used as an
identifier of a quota format in the options of quota tools (hence
renaming is higly unpleasant for admins). So I'm not sure that renaming
config options in kernel doesn't make things even more messy.
Honza
prev parent reply other threads:[~2004-01-09 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 15:59 Adrian Bunk
2004-01-07 16:11 ` Christoph Hellwig
2004-01-09 2:27 ` Adrian Bunk
2004-01-09 13:27 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109132731.GC28922@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=bunk@fs.tum.de \
--cc=hch@infradead.org \
--cc=jack@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®