mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andries Brouwer <aebr@win.tue.nl>
To: Nigel Cunningham <ncunningham@users.sourceforge.net>
Cc: root@chaos.analogic.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@digeo.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables
Date: Fri, 9 Jan 2004 21:33:27 +0100	[thread overview]
Message-ID: <20040109213327.A2699@pclin040.win.tue.nl> (raw)
In-Reply-To: <1073677435.2069.23.camel@laptop-linux>; from ncunningham@users.sourceforge.net on Sat, Jan 10, 2004 at 08:43:55AM +1300

>> Shouldn't we be using "size_t" for unsigned int

> You might be right. I was just being consistent with the other definitions.

These are character positions on a screen.
When did you last see a console in text mode with a line length
of more than 2^31 ?

If you go for a minimal patch then you should replace "char"
in one or two places by "unsigned char" and that is all.


  reply	other threads:[~2004-01-09 20:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-09 18:33 Nigel Cunningham
2004-01-09 19:22 ` Richard B. Johnson
2004-01-09 19:43   ` Nigel Cunningham
2004-01-09 20:33     ` Andries Brouwer [this message]
2004-01-09 21:26       ` Nigel Cunningham
2004-01-10  3:34         ` Edgar Toernig
2004-01-13 21:57     ` Pavel Machek
2004-01-09 21:32 ` Andrew Morton
2004-01-09 21:38 ` Andrew Morton
     [not found] <1c9S3-75-23@gated-at.bofh.it>
     [not found] ` <1cauN-131-17@gated-at.bofh.it>
     [not found]   ` <1cb7n-1Z6-17@gated-at.bofh.it>
     [not found]     ` <1cbAw-2BB-27@gated-at.bofh.it>
2004-01-16 18:41       ` Bill Davidsen
2004-01-16 18:54         ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040109213327.A2699@pclin040.win.tue.nl \
    --to=aebr@win.tue.nl \
    --cc=akpm@digeo.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@users.sourceforge.net \
    --cc=root@chaos.analogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®