From: Willem Riede <wrlk@riede.org>
To: linux-kernel@vger.kernel.org
Cc: Mikael Pettersson <mikpe@csd.uu.se>
Subject: Re: [PATCH][2.6] units= parameter for ide-scsi
Date: Sat, 10 Jan 2004 15:59:18 -0500 [thread overview]
Message-ID: <20040110205918.GK4339@linnie.riede.org> (raw)
In-Reply-To: <200401101502.i0AF2LOp022413@harpo.it.uu.se> (from mikpe@csd.uu.se on Sat, Jan 10, 2004 at 10:02:21 -0500)
On 2004.01.10 10:02, Mikael Pettersson wrote:
> This is my patch to add a "units=" parameter to ide-scsi.
> It's useful for people that, like me, have more than one
> ATAPI device in a machine. Sample usage:
I found that if only the existing hdx=ide-scsi mechanism had been
strictly enforced, this functionality had already existed:
--- linux-2.6.1/drivers/scsi/ide-scsi.c 2003-12-17 21:59:05.000000000 -0500
+++ /tmp/ide-scsi.c 2004-01-10 15:44:35.000000000 -0500
@@ -54,6 +54,9 @@
#include "hosts.h"
#include <scsi/sg.h>
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Scsi emulator for ATAPI Tape and MO devices");
+
#define IDESCSI_DEBUG_LOG 0
typedef struct idescsi_pc_s {
@@ -954,17 +957,18 @@
static int warned;
int err;
- if (!warned && drive->media == ide_cdrom) {
- printk(KERN_WARNING "ide-scsi is deprecated for cd burning! Use ide-cd and give dev=/dev/hdX as device\n");
- warned = 1;
- }
-
- if (!strstr("ide-scsi", drive->driver_req) ||
+ if (!drive->driver_req ||
+ !strstr(drive->driver_req, "ide-scsi") ||
!drive->present ||
drive->media == ide_disk ||
!(host = scsi_host_alloc(&idescsi_template,sizeof(idescsi_scsi_t))))
return 1;
+ if (!warned && drive->media == ide_cdrom) {
+ printk(KERN_WARNING "ide-scsi is deprecated for cd burning! Use ide-cd and give dev=/dev/hdX as device\n");
+ warned = 1;
+ }
+
host->max_id = 1;
host->max_lun = 1;
drive->driver_data = host;
@@ -1000,4 +1004,3 @@
module_init(init_idescsi_module);
module_exit(exit_idescsi_module);
-MODULE_LICENSE("GPL");
Regards, Willem Riede.
prev parent reply other threads:[~2004-01-10 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 15:02 Mikael Pettersson
2004-01-10 20:59 ` Willem Riede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040110205918.GK4339@linnie.riede.org \
--to=wrlk@riede.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®