From: Pavel Machek <pavel@ucw.cz>
To: john stultz <johnstul@us.ibm.com>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: suspend/resume support for PIT (time.c)
Date: Mon, 12 Jan 2004 23:39:15 +0100 [thread overview]
Message-ID: <20040112223915.GA204@elf.ucw.cz> (raw)
In-Reply-To: <1073932405.28098.43.camel@cog.beaverton.ibm.com>
Hi!
> On Sat, 2004-01-10 at 12:03, Pavel Machek wrote:
> > +static int pit_suspend(struct sys_device *dev, u32 state)
> [snip]
> > +static int pit_resume(struct sys_device *dev)
> > +{
> > + write_seqlock_irq(&xtime_lock);
> > + xtime.tv_sec = get_cmos_time() + clock_cmos_diff;
> > + xtime.tv_nsec = 0;
> > + write_sequnlock_irq(&xtime_lock);
> > + return 0;
> > +}
> [snip]
> > static struct sysdev_class pit_sysclass = {
> > + .resume = pit_resume,
> > + .suspend = pit_suspend,
> > set_kset_name("pit"),
> > };
>
> As none of this really has anything to do w/ the PIT, and to avoid
> confusion w/ the PIT timesource code, could we rename this to
> "time_suspend" and "time_resume"?
Applied, altrough I'll not try to push it for a while. (I'm not sure
if Andrew applied previous patches and do not want to clash).
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-01-12 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 20:03 Pavel Machek
2004-01-10 22:46 ` Andrew Morton
2004-01-11 11:53 ` Pavel Machek
2004-01-12 18:33 ` john stultz
2004-01-12 22:39 ` Pavel Machek [this message]
2004-01-12 23:12 ` Andrew Morton
2004-01-12 23:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040112223915.GA204@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome