mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: jh@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compilation on gcc 3.4
Date: Wed, 14 Jan 2004 00:49:44 -0800	[thread overview]
Message-ID: <20040114004944.5ba6b4a5.akpm@osdl.org> (raw)
In-Reply-To: <20040114083700.GA1820@averell>

Andi Kleen <ak@muc.de> wrote:
>
> 
> The upcomming gcc 3.4 has a new inlining algorithm which sometimes
> fails to inline some "dumb" inlines in the kernel. This sometimes leads
> to undefined symbols while linking.

That's a compiler bug, surely.

> To make the kernel compile again this patch drops the always inline
> for gcc 3.4.  The new algorithm should be good enough to do the right
> thing on its own. 

Are you sure?  Without the always_inline stuff we were seeing 100 different
copies of __constant_c_and_count_memset and friends in the vmlinux symbol
table.  It was really silly.

After applying this patch and building with gcc-3.4, how does `size
vmlinux' compare with the same kernel built with gcc-3.3, minus the patch?


  parent reply	other threads:[~2004-01-14  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14  8:37 Andi Kleen
2004-01-14  8:47 ` Jakub Jelinek
2004-01-14  8:58   ` Andi Kleen
2004-01-14 10:53     ` Jan Hubicka
2004-01-14  8:49 ` Andrew Morton [this message]
2004-01-14  9:04   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040114004944.5ba6b4a5.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@muc.de \
    --cc=jh@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®