From: Anton Blanchard <anton@samba.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adrian Bunk <bunk@fs.tum.de>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
eike-kernel@sf-tec.de, rth@twiddle.net, torvalds@osdl.org
Subject: Re: [2.6 patch] if ... BUG() -> BUG_ON()
Date: Fri, 16 Jan 2004 09:46:05 +1100 [thread overview]
Message-ID: <20040115224605.GB25094@krispykreme> (raw)
In-Reply-To: <20040115102048.4689664e.rusty@rustcorp.com.au>
> You know, I dislike this.
>
> The right fix is to hack gcc to allow functions (in this case, BUG()) to have
> an "unlikely" attribute, and therefore know that this branch is unlikely.
FYI the ppc32 and ppc64 BUG_ON avoids the branch completely thanks to
some clever code from paulus. Im not however advocating we rip through
the entire kernel and BUG_ON enable it :)
Anton
prev parent reply other threads:[~2004-01-15 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 21:32 Adrian Bunk
2004-01-14 23:20 ` Rusty Russell
2004-01-15 5:05 ` Richard Henderson
2004-01-15 22:46 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040115224605.GB25094@krispykreme \
--to=anton@samba.org \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®