mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: A little ctc cleanup
Date: Fri, 16 Jan 2004 12:23:36 -0800	[thread overview]
Message-ID: <20040116122336.66c48009.zaitcev@redhat.com> (raw)

Hi, Martin:

With the current state machine, doing fsm_event(DEV_EVENT_STOP) is an
exact equivalent of dev_action_stop, only it adds a (superfluous) debugging
tracepoint, which is useless anyway, because dev_action_restart is an action,
so its caller does the same.

My compliments to Fritz and please ask him to accept this.

-- Pete

--- linux-2.6.1-mm3/drivers/s390/net/ctcmain.c	2004-01-14 16:17:02.000000000 -0500
+++ linux-2.6.1-mm3-s390/drivers/s390/net/ctcmain.c	2004-01-16 11:12:29.000000000 -0500
@@ -2075,10 +2075,9 @@
 {
 	struct net_device *dev = (struct net_device *)arg;
 	struct ctc_priv *privptr = dev->priv;
-	
+
 	printk(KERN_DEBUG "%s: Restarting\n", dev->name);
 	dev_action_stop(fi, event, arg);
-	fsm_event(privptr->fsm, DEV_EVENT_STOP, dev);
 	fsm_addtimer(&privptr->restart_timer, CTC_TIMEOUT_5SEC,
 		     DEV_EVENT_START, dev);
 }


                 reply	other threads:[~2004-01-16 20:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040116122336.66c48009.zaitcev@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome