From: Andrew Morton <akpm@osdl.org>
To: Thomas Winischhofer <thomas@winischhofer.net>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] sisfb update 2.6.1
Date: Thu, 22 Jan 2004 01:23:12 -0800 [thread overview]
Message-ID: <20040122012312.1f26fad8.akpm@osdl.org> (raw)
In-Reply-To: <400F9055.5050206@winischhofer.net>
Thomas Winischhofer <thomas@winischhofer.net> wrote:
>
> > It still has floating point stuff in sis_init(). Could you please
> > review, integrate and test the below patch?
>
> sis_init()? You probably mean sis/init.c?
>
> Anyway: Irrelevant. This code part isn't even being compiled for the
> linux kernel (See line 4304 - #ifdef LINUX_XF86).
Well darn, that patch fixed the wrong bit and we still have float in there.
allmodconfig doesn't pick this up.
drivers/built-in.o: In function `sisfb_do_set_var':
//drivers/video/sis/sis_main.c:654: undefined reference to `__floatsidf'
...
drivers/built-in.o: In function `sisfb_init':
//drivers/video/sis/sis_main.c:4450: undefined reference to `__floatsidf'
Search for "1E12" in sis_main.c
Here's the patch which adds -msoft-float to the kernel build, which picks
up these things.
--- 25/arch/i386/Makefile~use-soft-float 2004-01-07 10:36:36.000000000 -0800
+++ 25-akpm/arch/i386/Makefile 2004-01-07 10:36:36.000000000 -0800
@@ -19,7 +19,7 @@ LDFLAGS := -m elf_i386
OBJCOPYFLAGS := -O binary -R .note -R .comment -S
LDFLAGS_vmlinux :=
-CFLAGS += -pipe
+CFLAGS += -pipe -msoft-float
# prevent gcc from keeping the stack 16 byte aligned
CFLAGS += $(call check_gcc,-mpreferred-stack-boundary=2,)
_
next prev parent reply other threads:[~2004-01-22 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-21 23:47 Thomas Winischhofer
2004-01-22 0:03 ` Andrew Morton
2004-01-22 8:56 ` Thomas Winischhofer
2004-01-22 9:23 ` Andrew Morton [this message]
2004-01-22 10:19 ` Thomas Winischhofer
2004-01-22 10:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122012312.1f26fad8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome