From: Nathan Scott <nathans@sgi.com>
To: davej@redhat.com, marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org
Subject: Re: logic error in XFS
Date: Sat, 24 Jan 2004 11:41:13 +1100 [thread overview]
Message-ID: <20040124114113.A3508196@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <E1Ajuub-0000xw-00@hardwired>; from davej@redhat.com on Fri, Jan 23, 2004 at 06:35:25AM +0000
On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Yet another misplaced ! by the looks..
>
Thanks Dave, your fix looks good to me too. Marcelo, this affects
2.4 too - please apply this patch.
thanks.
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
> --- bk-linus/fs/xfs/xfs_log_recover.c 2003-10-09 01:01:24.000000000 +0100
> +++ linux-2.5/fs/xfs/xfs_log_recover.c 2004-01-14 07:06:40.000000000 +0000
> @@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
> case XFS_LI_BUF:
> case XFS_LI_6_1_BUF:
> case XFS_LI_5_3_BUF:
> - if ((!flags & XFS_BLI_CANCEL)) {
> + if (!(flags & XFS_BLI_CANCEL)) {
> xlog_recover_insert_item_frontq(&trans->r_itemq,
> itemq);
> break;
--
Nathan
prev parent reply other threads:[~2004-01-24 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 davej
2004-01-23 9:33 ` Måns Rullgård
[not found] ` <yw1xr7xr80wi.fsf@adic.com>
2004-01-23 15:55 ` Steve Lord
2004-01-24 0:41 ` Nathan Scott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040124114113.A3508196@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®