mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: eric@cisu.net, sboyce@blueyonder.co.uk,
	linux-kernel@vger.kernel.org, bunk@fs.tum.de, torvalds@osdl.org
Subject: Re: 2.6.2-rc1-mm2 kernel oops
Date: Sun, 25 Jan 2004 16:04:00 -0800	[thread overview]
Message-ID: <20040125160400.5b9d2e88.akpm@osdl.org> (raw)
In-Reply-To: <20040125152559.55165860.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:
>
> Eric <eric@cisu.net> wrote:
> >  Now I get the test_wp_bit oops w/ 
> ...
> 
> init/main.c does
> 
> 	mem_init();
> 	kmem_cache_init();
> 	sort_main_extable();
> 
> but mem_init() calls test_wp_bit().  The exception tables haven't been
> sorted yet.
> 

Well I don't see any reason why the obvious should not work.  It boots OK
on i386 but whether other architectures do things in mem_init() which must
be done prior to exception table sorting, I know not.  It seems unlikely.

Can you see if this patch makes the test_wp_bit() oops go away?

 
diff -puN init/main.c~test_wp_bit-oops-fix init/main.c
--- 25/init/main.c~test_wp_bit-oops-fix	2004-01-25 15:29:53.000000000 -0800
+++ 25-akpm/init/main.c	2004-01-25 15:30:03.000000000 -0800
@@ -434,9 +434,9 @@ asmlinkage void __init start_kernel(void
 	}
 #endif
 	page_address_init();
+	sort_main_extable();
 	mem_init();
 	kmem_cache_init();
-	sort_main_extable();
 	if (late_time_init)
 		late_time_init();
 	calibrate_delay();

_


  reply	other threads:[~2004-01-26  0:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-25 14:20 Sid Boyce
2004-01-25 20:11 ` John Stoffel
2004-01-25 20:34   ` Sid Boyce
2004-01-25 23:14     ` Eric
2004-01-25 23:25       ` Andrew Morton
2004-01-26  0:04         ` Andrew Morton [this message]
2004-01-26  6:33           ` Eric
  -- strict thread matches above, loose matches on Subject: below --
2004-01-25 20:21 Sid Boyce
2004-01-25 15:14 Sid Boyce
2004-01-25 18:08 ` Adrian Bunk
2004-01-23 23:15 Sid Boyce
2004-01-24  5:12 ` Andrew Morton
2004-01-24  6:26   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040125160400.5b9d2e88.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=eric@cisu.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyce@blueyonder.co.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®