From: Adrian Bunk <bunk@fs.tum.de>
To: andre@linux-ide.org, Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.4 patch] fix two IDE warnings
Date: Mon, 26 Jan 2004 04:19:21 +0100 [thread overview]
Message-ID: <20040126031921.GZ513@fs.tum.de> (raw)
I got the following warnings in 2.4.25-pre7:
<-- snip -->
...
gcc-2.95 -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.25-pre7-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6 -I../
-nostdinc -iwithprefix include -DKBUILD_BASENAME=siimage -c -o
siimage.o siimage.c
siimage.c: In function `pdev_is_sata':
siimage.c:65: warning: control reaches end of non-void function
...
gcc-2.95 -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.25-pre7-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6 -I../
-nostdinc -iwithprefix include -DKBUILD_BASENAME=generic -c -o
generic.o generic.c
generic.h:151: warning: `unknown_chipset' defined but not used
...
<-- snip -->
The patch below (completely stolen from 2.6) fixes these two warnings.
Please apply
Adrian
--- linux-2.4.25-pre7-full/drivers/ide/pci/siimage.c.old 2004-01-26 04:02:58.000000000 +0100
+++ linux-2.4.25-pre7-full/drivers/ide/pci/siimage.c 2004-01-26 04:03:16.000000000 +0100
@@ -62,6 +62,7 @@
return 0;
}
BUG();
+ return 0;
}
/**
--- linux-2.4.25-pre7-full/drivers/ide/pci/generic.h.old 2004-01-26 04:05:31.000000000 +0100
+++ linux-2.4.25-pre7-full/drivers/ide/pci/generic.h 2004-01-26 04:05:46.000000000 +0100
@@ -148,6 +148,7 @@
}
};
+#if 0
static ide_pci_device_t unknown_chipset[] __devinitdata = {
{ /* 0 */
.vendor = 0,
@@ -170,5 +171,6 @@
}
};
+#endif
#endif /* IDE_GENERIC_H */
reply other threads:[~2004-01-26 3:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040126031921.GZ513@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®