From: "Randy.Dunlap" <rddunlap@osdl.org>
To: jw schultz <jw@pegasys.ws>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: Trailing blanks in source files
Date: Tue, 27 Jan 2004 19:55:58 -0800 [thread overview]
Message-ID: <20040127195558.342dba6c.rddunlap@osdl.org> (raw)
In-Reply-To: <20040128034939.GE15979@pegasys.ws>
On Tue, 27 Jan 2004 19:49:39 -0800 jw schultz <jw@pegasys.ws> wrote:
| On Tue, Jan 27, 2004 at 04:02:14PM -0800, Andrew Morton wrote:
| > "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| > >
| > > So please don't bother with just whitespace changes unless you
| > > are going to cleanup a <driver | fs | module | etc> completely.
| >
| > And if you're going to do that, do the whitespace cleanup _first_, so the
| > substantive changes to the driver/fs/module/etc can be sanely understood
| > and reverted if necessary.
| >
| > I frequently sneakily remove all newly-added trailing whitespace from the
| > patches people send me. In 15 years it'll all be gone.
|
| This would maybe warrant a bk option to remove trailing
| whitespace from modified lines. Preferably with an
| notification that it is happening so if for some reason you
| do want trailing whitespace you could abort or override.
|
| A patch filter that removed trailing whitespace from + lines
| could also be used.
AFAIK Andrew already uses a script to check for trailing spaces,
and I do also. Yes, it could be modified to be a conversion filter,
but it doesn't happen frequently, and when it does, I want to let
the poster know about it, so I like to have the evidence handy. :)
--
~Randy
next prev parent reply other threads:[~2004-01-28 3:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.58.0401271544120.27260@joel.ist.utl.pt.suse.lists.linux.kernel>
2004-01-27 18:34 ` Andi Kleen
2004-01-27 18:51 ` Joseph D. Wagner
2004-01-27 19:13 ` David Weinehall
2004-01-27 19:18 ` Randy.Dunlap
2004-01-28 0:02 ` Andrew Morton
2004-01-28 3:49 ` jw schultz
2004-01-28 3:55 ` Randy.Dunlap [this message]
2004-01-28 4:53 ` Pragnesh Sampat
2004-01-27 19:31 ` Paulo Marques
2004-01-28 22:15 ` Paul Jackson
2004-01-28 22:22 ` David Weinehall
2004-01-27 19:14 ` linux
2004-01-27 15:44 Rui Saraiva
2004-01-27 16:15 ` YOSHIFUJI Hideaki / 吉藤英明
2004-01-27 16:30 ` Bas Mevissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040127195558.342dba6c.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=jw@pegasys.ws \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®