From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266040AbUA1Rsb (ORCPT ); Wed, 28 Jan 2004 12:48:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266066AbUA1Rsb (ORCPT ); Wed, 28 Jan 2004 12:48:31 -0500 Received: from gprs192-165.eurotel.cz ([160.218.192.165]:9859 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S266040AbUA1Rs2 (ORCPT ); Wed, 28 Jan 2004 12:48:28 -0500 Date: Wed, 28 Jan 2004 18:46:55 +0100 From: Pavel Machek To: schierlm@gmx.de Cc: fr@canb.auug.org.au, linux-laptop@vger.kernel.org, linux-kernel@vger.kernel.org, mochel@digitalimplant.org Subject: Re: [PATCH] [APM] Is this the correct way to fix suspend bug introduced in 2.6.0-test4? Message-ID: <20040128174655.GE1200@elf.ucw.cz> References: <13zy7qdcyz1q7$.50e5l3rpbsyx$.dlg@40tude.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13zy7qdcyz1q7$.50e5l3rpbsyx$.dlg@40tude.net> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > the patch below (against 2.6.1-mm5) fixes my APM problems (my laptop, Acer > TravelMate 210TEV (Celeron 700, 128 MB RAM), hangs after resuming from APM > since 2.6.0-test4). > > I found the "fix" by trying to "reversely" backport the changes from > patch-2.6.0-test4.bz2 into 2.6.1-mm5 (the old device_suspend code calls > sysdev_suspend, the new one does not; so what do I lose if I call > sysdev_suspend myself?). This trial-and-error-approach finally led into the > patch below (which works great for me). > > Most likely this is not the cleanest way to do this; but since I don't even > know what this sysdev_suspend does (except that it does something that > seems to be vital for making my laptop resume...), i don't know how to make > it better... > > If you have any suggestions, tell me (or change it yourself and submit it), > if you think that's okay like that, please submit that to the guy who is > responsible for 2.6 (is it Linus or Andrew? did not follow lkml > recently). Andrew. I think you should use device_power_down() and device_power_up(), instead. Check it, but it looks to me like that's better way. Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]