From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>,
moilanen@austin.ibm.com, johnrose@austin.ibm.com,
linux-kernel@vger.kernel.org, torvalds@osdl.org,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH][2.6] PCI Scan all functions
Date: Wed, 28 Jan 2004 23:58:15 +0300 [thread overview]
Message-ID: <20040128235815.A8539@den.park.msu.ru> (raw)
In-Reply-To: <20040127214444.GA27874@kroah.com>; from greg@kroah.com on Tue, Jan 27, 2004 at 01:44:44PM -0800
On Tue, Jan 27, 2004 at 01:44:44PM -0800, Greg KH wrote:
> > - if (base && base <= limit) {
> > + if (base <= limit) {
I think the patch is safe. Architectures that don't accept
bridge windows (and regular BARs) at bus address 0 already have
that check elsewhere.
For example, in arch/i386/pci/i386.c:pcibios_allocate_bus_resources():
...
for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
r = &dev->resource[idx];
if (!r->start)
^^^^^^^^^
continue;
...
Ivan.
next prev parent reply other threads:[~2004-01-28 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 16:55 Jake Moilanen
2004-01-27 21:12 ` Greg KH
2004-01-27 21:33 ` Andrew Morton
2004-01-27 21:44 ` Greg KH
2004-01-28 20:58 ` Ivan Kokshaysky [this message]
2004-01-27 21:57 ` Linus Torvalds
2004-01-27 21:57 ` John Rose
2004-01-28 15:41 ` Martin Mares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128235815.A8539@den.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=greg@kroah.com \
--cc=johnrose@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moilanen@austin.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®