From: Adam Belay <ambx1@neo.rr.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PnP Updates for 2.6.2-rc2
Date: Thu, 29 Jan 2004 23:55:04 +0000 [thread overview]
Message-ID: <20040129235504.GB12308@neo.rr.com> (raw)
In-Reply-To: <20040129235304.GA12308@neo.rr.com>
The serial driver currently fails to unregister its pnp driver upon module
unload. This patch corrects the problem by calling pnp_unregister_driver and
implementing a proper remove function.
--- a/drivers/serial/8250_pnp.c 2004-01-28 22:35:02.000000000 +0000
+++ b/drivers/serial/8250_pnp.c 2004-01-28 22:33:40.000000000 +0000
@@ -418,7 +418,9 @@
static void serial_pnp_remove(struct pnp_dev * dev)
{
- return;
+ int line = (int)pnp_get_drvdata(dev);
+ if (line)
+ unregister_serial(line - 1);
}
static struct pnp_driver serial_pnp_driver = {
@@ -435,7 +437,7 @@
static void __exit serial8250_pnp_exit(void)
{
- /* FIXME */
+ pnp_unregister_driver(&serial_pnp_driver);
}
module_init(serial8250_pnp_init);
next prev parent reply other threads:[~2004-01-30 5:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-29 23:53 Adam Belay
2004-01-29 23:55 ` Adam Belay [this message]
2004-01-29 23:56 ` Adam Belay
2004-01-29 23:57 ` Adam Belay
2004-01-29 23:57 ` Adam Belay
2004-01-29 23:59 ` Adam Belay
2004-01-29 23:59 ` Adam Belay
2004-01-30 0:00 ` Adam Belay
2004-01-30 0:01 ` Adam Belay
2004-01-30 0:02 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040129235504.GB12308@neo.rr.com \
--to=ambx1@neo.rr.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome