From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Jeff Hartmann <jhartmann@precisioninsight.com>,
davej@codemonkey.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: [2.4 patch] fix a agpgart_be.c compile warning
Date: Fri, 30 Jan 2004 20:59:46 +0100 [thread overview]
Message-ID: <20040130195945.GR3004@fs.tum.de> (raw)
I got the following compile warning in 2.4.25-pre8:
<-- snip -->
...
gcc -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.25-pre8-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6
-nostdinc -iwithprefix include -DKBUILD_BASENAME=agpgart_be -c -o agpgart_be.o
agpgart_be.c
...
agpgart_be.c:5647:17: warning: extra tokens at end of #undef directive
...
<-- snip -->
The following patch fixes this issue:
--- linux-2.4.25-pre8-full/drivers/char/agp/agpgart_be.c.old 2004-01-30 20:55:15.000000000 +0100
+++ linux-2.4.25-pre8-full/drivers/char/agp/agpgart_be.c 2004-01-30 20:55:53.000000000 +0100
@@ -5644,7 +5644,7 @@
#define GET_PAGE_DIR_IDX(addr) (GET_PAGE_DIR_OFF(addr) - \
GET_PAGE_DIR_OFF(agp_bridge.gart_bus_addr))
#define GET_GATT_OFF(addr) ((addr & 0x003ff000) >> 12)
-#undef GET_GATT(addr)
+#undef GET_GATT
#define GET_GATT(addr) (ati_generic_private.gatt_pages[\
GET_PAGE_DIR_IDX(addr)]->remapped)
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
reply other threads:[~2004-01-30 19:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040130195945.GR3004@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=davej@codemonkey.org.uk \
--cc=jhartmann@precisioninsight.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome