From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Roland McGrath <roland@redhat.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restore protections after forced fault in get_user_pages
Date: Tue, 3 Feb 2004 09:29:49 +0100 [thread overview]
Message-ID: <20040203082949.GA1116@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0402021616340.9720@home.osdl.org>
* Linus Torvalds <torvalds@osdl.org> wrote:
> > I think this question is orthogonal to my concern about follow_page.
>
> The follow_page issue should be fixable by just marking the _page_
> dirty inside the ptrace routines. I think we do that anyway (or we'd
> already be buggy wrt perfectly normal writes).
the follow_page() issue could be handled like the 4/4 patch does it: a
repeat-until loop of manual-fault + lookup-pte (we break out of the loop
if the manual fault fails or when the lookup is successful). The race
window is so small that the repeating solution is i think far superior
to artificially dirtying the pte.
Ingo
next prev parent reply other threads:[~2004-02-03 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 7:29 Roland McGrath
2004-02-02 22:46 ` Andrew Morton
2004-02-02 23:09 ` Linus Torvalds
2004-02-02 23:48 ` Roland McGrath
2004-02-02 23:55 ` Linus Torvalds
2004-02-03 0:03 ` Roland McGrath
2004-02-03 0:09 ` Roland McGrath
2004-02-03 0:30 ` Linus Torvalds
2004-02-03 0:42 ` Andrew Morton
2004-02-03 0:55 ` Roland McGrath
2004-02-03 8:29 ` Ingo Molnar [this message]
2004-02-03 10:25 ` Roland McGrath
2004-02-03 17:04 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203082949.GA1116@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®