From: Kronos <kronos@kronoz.cjb.net>
To: "Richard B. Johnson" <root@chaos.analogic.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Compile Regression in 2.4.25-pre8][PATCH 11/42]
Date: Tue, 3 Feb 2004 22:04:58 +0100 [thread overview]
Message-ID: <20040203210458.GA1337@dreamland.darkstar.lan> (raw)
In-Reply-To: <Pine.LNX.4.53.0402021622390.28946@chaos>
Il Mon, Feb 02, 2004 at 04:25:55PM -0500, Richard B. Johnson ha scritto:
> On Mon, 2 Feb 2004, Kronos wrote:
>
> >
> > include/asm/smpboot.h:126: warning: deprecated use of label at end of compound statement
> >
> > Move the return statement under 'default' label to suppress the warning.
> >
> > diff -Nru -X dontdiff linux-2.4-vanilla/include/asm-i386/smpboot.h linux-2.4/include/asm-i386/smpboot.h
> > --- linux-2.4-vanilla/include/asm-i386/smpboot.h Tue Nov 11 17:51:14 2003
> > +++ linux-2.4/include/asm-i386/smpboot.h Sat Jan 31 17:10:50 2004
> > @@ -123,8 +123,8 @@
> > cpu = (cpu+1)%smp_num_cpus;
> > return cpu_to_physical_apicid(cpu);
> > default:
> > + return cpu_online_map;
> > }
> > - return cpu_online_map;
> > }
> > #else
> > #define target_cpus() (cpu_online_map)
> >
>
> Not correct. This removes the main-line return of a value.
Since the original code is this:
switch(clustered_apic_mode){
case CLUSTERED_APIC_NUMAQ:
/* Broadcast intrs to local quad only. */
return APIC_BROADCAST_ID_APIC;
case CLUSTERED_APIC_XAPIC:
/*round robin the interrupts*/
cpu = (cpu+1)%smp_num_cpus;
return cpu_to_physical_apicid(cpu);
default:
}
return cpu_online_map;
my patch doesn't change anything. It may be a bit unclean though. What
about this one:
diff -Nru -X dontdiff linux-2.4-vanilla/include/asm-i386/smpboot.h linux-2.4/include/asm-i386/smpboot.h
--- linux-2.4-vanilla/include/asm-i386/smpboot.h Sun Aug 31 23:04:50 2003
+++ linux-2.4/include/asm-i386/smpboot.h Tue Feb 3 22:03:06 2004
@@ -123,6 +123,7 @@
cpu = (cpu+1)%smp_num_cpus;
return cpu_to_physical_apicid(cpu);
default:
+ break;
}
return cpu_online_map;
}
Luca
--
Reply-To: kronos@kronoz.cjb.net
Home: http://kronoz.cjb.net
I went to God just to see
And I was looking at me
Saw heaven and hell were lies
When I'm God everyone dies
next prev parent reply other threads:[~2004-02-03 21:05 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-30 18:15 [Compile Regression] 2.4.25-pre8: 126 warnings 0 errors Xose Vazquez Perez
2004-01-30 18:40 ` Xose Vazquez Perez
2004-01-30 19:11 ` Marcelo Tosatti
2004-01-30 20:49 ` Kronos
[not found] ` <Pine.LNX.4.58L.0401301855410.3140@logos.cnet>
2004-02-02 18:09 ` Kronos
2004-02-02 18:19 ` [Compile Regression in 2.4.25-pre8][PATCH 1/42] Kronos
2004-02-02 18:20 ` [Compile Regression in 2.4.25-pre8][PATCH 2/42] Kronos
2004-02-02 18:21 ` [Compile Regression in 2.4.25-pre8][PATCH 3/42] Kronos
2004-02-02 18:21 ` [Compile Regression in 2.4.25-pre8][PATCH 4/42] Kronos
2004-02-02 18:26 ` [Compile Regression in 2.4.25-pre8][PATCH 5/42] Kronos
2004-02-02 18:43 ` [Compile Regression in 2.4.25-pre8][PATCH 6/42] Kronos
2004-02-02 19:42 ` [Compile Regression in 2.4.25-pre8][PATCH 7/42] Kronos
2004-02-02 19:42 ` [Compile Regression in 2.4.25-pre8][PATCH 8/42] Kronos
2004-02-02 19:43 ` [Compile Regression in 2.4.25-pre8][PATCH 9/42] Kronos
2004-02-02 19:44 ` [Compile Regression in 2.4.25-pre8][PATCH 10/42] Kronos
2004-02-02 19:44 ` [Compile Regression in 2.4.25-pre8][PATCH 11/42] Kronos
2004-02-02 21:25 ` Richard B. Johnson
2004-02-03 21:04 ` Kronos [this message]
2004-02-04 12:27 ` Richard B. Johnson
2004-02-02 19:45 ` [Compile Regression in 2.4.25-pre8][PATCH 12/42] Kronos
2004-02-02 19:45 ` [Compile Regression in 2.4.25-pre8][PATCH 13/42] Kronos
2004-02-02 19:46 ` [Compile Regression in 2.4.25-pre8][PATCH 14/42] Kronos
2004-02-02 19:46 ` [Compile Regression in 2.4.25-pre8][PATCH 15/42] Kronos
2004-02-04 16:46 ` Marcelo Tosatti
2004-02-04 20:19 ` Kronos
2004-02-02 19:46 ` [Compile Regression in 2.4.25-pre8][PATCH 16/42] Kronos
2004-02-02 21:51 ` Marcelo Tosatti
2004-02-02 19:47 ` [Compile Regression in 2.4.25-pre8][PATCH 17/42] Kronos
2004-02-02 19:47 ` [Compile Regression in 2.4.25-pre8][PATCH 18/42] Kronos
2004-02-02 19:48 ` [Compile Regression in 2.4.25-pre8][PATCH 19/42] Kronos
2004-02-02 19:48 ` [Compile Regression in 2.4.25-pre8][PATCH 20/42] Kronos
2004-02-02 19:48 ` [Compile Regression in 2.4.25-pre8][PATCH 21/42] Kronos
2004-02-02 19:56 ` [Compile Regression in 2.4.25-pre8][PATCH 22/42] Kronos
2004-02-02 19:57 ` [Compile Regression in 2.4.25-pre8][PATCH 23/42] Kronos
2004-02-02 19:57 ` [Compile Regression in 2.4.25-pre8][PATCH 24/42] Kronos
2004-02-02 19:57 ` [Compile Regression in 2.4.25-pre8][PATCH 25/42] Kronos
2004-02-02 19:58 ` [Compile Regression in 2.4.25-pre8][PATCH 26/42] Kronos
2004-02-02 19:58 ` [Compile Regression in 2.4.25-pre8][PATCH 27/42] Kronos
2004-02-02 19:58 ` [Compile Regression in 2.4.25-pre8][PATCH 28/42] Kronos
2004-02-02 19:58 ` [Compile Regression in 2.4.25-pre8][PATCH 29/42] Kronos
2004-02-02 19:59 ` [Compile Regression in 2.4.25-pre8][PATCH 30/42] Kronos
2004-02-02 20:00 ` [Compile Regression in 2.4.25-pre8][PATCH 31/42] Kronos
2004-02-02 20:01 ` [Compile Regression in 2.4.25-pre8][PATCH 32/42] Kronos
2004-02-02 20:01 ` [Compile Regression in 2.4.25-pre8][PATCH 33/42] Kronos
2004-02-02 20:02 ` [Compile Regression in 2.4.25-pre8][PATCH 34/42] Kronos
2004-02-02 20:03 ` [Compile Regression in 2.4.25-pre8][PATCH 35/42] Kronos
2004-02-02 20:03 ` [Compile Regression in 2.4.25-pre8][PATCH 36/42] Kronos
2004-02-02 20:03 ` [Compile Regression in 2.4.25-pre8][PATCH 37/42] Kronos
2004-02-02 21:08 ` Geert Uytterhoeven
2004-02-02 21:25 ` Kronos
2004-02-03 21:07 ` Kronos
2004-02-03 23:14 ` Philippe Elie
2004-02-04 20:22 ` Kronos
2004-02-02 20:04 ` [Compile Regression in 2.4.25-pre8][PATCH 38/42] Kronos
2004-02-02 20:04 ` [Compile Regression in 2.4.25-pre8][PATCH 39/42] Kronos
2004-02-02 20:05 ` [Compile Regression in 2.4.25-pre8][PATCH 40/42] Kronos
2004-02-02 20:05 ` [Compile Regression in 2.4.25-pre8][PATCH 41/42] Kronos
2004-02-02 20:06 ` [Compile Regression in 2.4.25-pre8][PATCH 42/42] Kronos
2004-01-30 22:18 ` [Compile Regression] 2.4.25-pre8: 126 warnings 0 errors Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203210458.GA1337@dreamland.darkstar.lan \
--to=kronos@kronoz.cjb.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=root@chaos.analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®