From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262580AbUBDLwJ (ORCPT ); Wed, 4 Feb 2004 06:52:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262838AbUBDLwJ (ORCPT ); Wed, 4 Feb 2004 06:52:09 -0500 Received: from broremann2.ux.his.no ([152.94.1.11]:24765 "EHLO broremann2.ux.his.no") by vger.kernel.org with ESMTP id S262580AbUBDLwG (ORCPT ); Wed, 4 Feb 2004 06:52:06 -0500 Date: Wed, 4 Feb 2004 12:51:28 +0100 From: Erlend Aasland To: Vojtech Pavlik Cc: Linux Kernel Mailing List Subject: [PATCH] Sun Keyboard driver Message-ID: <20040204115128.GA25798@badne4.ux.his.no> Reply-To: Erlend Aasland Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, I noticed a small bug in the sunkbd.c driver: After the keyboard name is set, it is mistakenly overwritten by serio->phys. Path is against 2.6.2. Regards, Erlend Aasland --- drivers/input/keyboard/sunkbd.c~ 2004-02-04 13:06:44.603610000 +0100 +++ drivers/input/keyboard/sunkbd.c 2004-02-04 13:09:00.603610000 +0100 @@ -275,7 +275,7 @@ set_bit(sunkbd->keycode[i], sunkbd->dev.keybit); clear_bit(0, sunkbd->dev.keybit); - sprintf(sunkbd->name, "%s/input", serio->phys); + sprintf(sunkbd->phys, "%s/input", serio->phys); sunkbd->dev.name = sunkbd->name; sunkbd->dev.phys = sunkbd->phys;