From: Vojtech Pavlik <vojtech@suse.cz>
To: Erlend Aasland <erlend-a@ux.his.no>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Sun Keyboard driver
Date: Wed, 4 Feb 2004 13:24:03 +0100 [thread overview]
Message-ID: <20040204122403.GA447@ucw.cz> (raw)
In-Reply-To: <20040204115128.GA25798@badne4.ux.his.no>
On Wed, Feb 04, 2004 at 12:51:28PM +0100, Erlend Aasland wrote:
> Hi,
>
> I noticed a small bug in the sunkbd.c driver: After the keyboard name is
> set, it is mistakenly overwritten by serio->phys. Path is against 2.6.2.
Thanks for noticing, it's already fixed in my tree.
>
> Regards,
> Erlend Aasland
>
> --- drivers/input/keyboard/sunkbd.c~ 2004-02-04 13:06:44.603610000 +0100
> +++ drivers/input/keyboard/sunkbd.c 2004-02-04 13:09:00.603610000 +0100
> @@ -275,7 +275,7 @@
> set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
> clear_bit(0, sunkbd->dev.keybit);
>
> - sprintf(sunkbd->name, "%s/input", serio->phys);
> + sprintf(sunkbd->phys, "%s/input", serio->phys);
>
> sunkbd->dev.name = sunkbd->name;
> sunkbd->dev.phys = sunkbd->phys;
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
prev parent reply other threads:[~2004-02-04 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 11:51 Erlend Aasland
2004-02-04 12:24 ` Vojtech Pavlik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040204122403.GA447@ucw.cz \
--to=vojtech@suse.cz \
--cc=erlend-a@ux.his.no \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®