From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265118AbUBEAec (ORCPT ); Wed, 4 Feb 2004 19:34:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265102AbUBEAZl (ORCPT ); Wed, 4 Feb 2004 19:25:41 -0500 Received: from fw.osdl.org ([65.172.181.6]:58077 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S264291AbUBEAPB (ORCPT ); Wed, 4 Feb 2004 19:15:01 -0500 Date: Wed, 4 Feb 2004 16:16:26 -0800 From: Andrew Morton To: Tom Rini Cc: pavel@ucw.cz, linux-kernel@vger.kernel.org Subject: Re: kgdb support in vanilla 2.6.2 Message-Id: <20040204161626.1a2f8885.akpm@osdl.org> In-Reply-To: <20040204235508.GB1086@smtp.west.cox.net> References: <20040204230133.GA8702@elf.ucw.cz> <20040204152137.500e8319.akpm@osdl.org> <20040204232447.GC256@elf.ucw.cz> <20040204235508.GB1086@smtp.west.cox.net> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Tom Rini wrote: > > Andrew, what features of George's version don't you like? This is bad: akpm:/usr/src/25> grep '^+#ifdef' patches/kgdb-ga.patch | wc -l 83 and the fact that it touches 36 different files. Any time I've had to do any maintenance work against that stub I get lost in a twisty maze and just whine at George about it. It's just all over the place. Yes, this is partly the nature of the beast, but I don't see that a ton of effort has been put into reducing the straggliness. > Right now > I'm working on moving the kgdb-eth driver that uses netpoll over > into Amit's version, and thinking of a cleaner away to allow for both > early debugging and multiple drivers (eth or serial A or serial B). Sounds good. Look, there's a lot of interest in this and I of course am fully supportive. If someone could send me Amit's patchset when they think I should test it, I could then talk about it more usefully.