Re: [PATCH] powernow-k8 max speed sanity check

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > Well, I wanted some way to detect exactly this broken machine. You
> > might want to simply put == 8 there.. but proper solution is DMI blacklist. 
> 
> Or just use the current running values for max speed. That will fail if the
> system boots at lower speeds on battery though. And the BIOS checks will
> fail on buggy BIOSes and when upgrading the CPU. So maybe use both checks?

Well... for your own kernel hack it any way you want.

For public consumtion... I guess DMI blacklist and assume user did not
exchange cpus... We could cross-check /proc/cpuinfo.

> > > What do you think about using module options maxfid and maxvid?
> > 
> > Well, the original BIOS has not only maximum values wrong, but also
> > 1600MHz wrong, as far as I can tell...
> 
> Outch! I did not know that...
> 
> Are the middle values needed? What if you only use the min and max 
> fid/vid values, and always recalculate the stepping tables from those 
> values?

Well, 1600MHz operation is very nice, as it has significantly less
power consumption but pretty much same performance. It also does not
start CPU fan most of the time :-).  

								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]