Re: [PATCH 2.6.2] Documentation/SubmittingPatches

[jw schultz <jw@pegasys.ws>]

On Wed, Feb 04, 2004 at 11:23:03PM -0800, Bryan Whitehead wrote:
> 
> I've been trying to get my feet wet by submitting trivial patchs to various maintainers and the responses have been, "your not submiting you patches correctly". It seems most developers/maintainers want a diff done like this:
> 
> cd /source-tree
> diff -u linux-2.6.2/FileToPatch.orig linux-2.6.2/FileToPatch
> 
> instead of the "SubmitingPatches" document way:
> cd /source-tree/linux-2.6.2
> diff -u FileToPatch.orig FileToPatch
> 
> It would be _great_ if the Documentation was more accurate to the taste of developers/maintainers...
> 
> If the SubmittingPatches document is correct, then just toss this patch out because this won't be submitted right... ;)
> 
> --- linux-2.6.2/Documentation/SubmittingPatches.orig    2004-02-04 22:57:55.818563016 -0800
> +++ linux-2.6.2/Documentation/SubmittingPatches 2004-02-04 23:01:28.799185040 -0800
> @@ -33,13 +33,15 @@
>                                                                                                                                     
>  To create a patch for a single file, it is often sufficient to do:
>                                                                                                                                     
> -       SRCTREE= /devel/linux-2.4
> +       SRCTREE= /devel/
> +       SRCDIR= linux-2.4
>         MYFILE=  drivers/net/mydriver.c
>                                                                                                                                     
> -       cd $SRCTREE
> +       cd $SRCTREE/$SRCDIR
>         cp $MYFILE $MYFILE.orig
>         vi $MYFILE      # make your change
> -       diff -u $MYFILE.orig $MYFILE > /tmp/patch
> +       cd $SRCTREE
> +       diff -u $SRCDIR/$MYFILE.orig $SRCDIR/$MYFILE > /tmp/patch
>                                                                                                                                     

For what it may be worth I find patches a lot more useful
for review purposes if the -p (for --show-c-function) option
is also used.

-- 
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		jw@pegasys.ws

		Remember Cernan and Schmitt