mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: John Cherry <cherry@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: IA32 (2.6.2 - 2004-02-05.22.30) - 3 New warnings (gcc 3.2.2)
Date: Fri, 6 Feb 2004 19:35:08 +0100	[thread overview]
Message-ID: <20040206183508.GA3268@vana.vc.cvut.cz> (raw)
In-Reply-To: <20040206182208.GI21151@parcelfarce.linux.theplanet.co.uk>

On Fri, Feb 06, 2004 at 06:22:08PM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> 
> Umm...  How about
> 
> static inline void BUG() __attribute__((noreturn));
> 
> static inline void BUG(void)
> {
> 	__asm__ ....
> }

Unfortunately gcc thinks that it knows better than you whether function
can return or not. I attempted to use noreturn attribute in couple of
my projects, but it is useless - unless you terminate your function
with for(;;) or with call to _exit(), it won't work.

vana:~# more m.c
static inline void BUG() __attribute__((noreturn));

static inline void BUG(void) {
        __asm__ ("1: jmp 1b");
}

void main(void) {
        BUG();
}

vana:~# gcc -W -Wall m.c
m.c:7: warning: return type of `main' is not `int'
m.c: In function `BUG':
m.c:3: warning: `noreturn' function does return
vana:~#

(gcc version 3.3.3 20040125 (prerelease) (Debian))

> > Better to just initialize the variable to a default value and avoid the 
> > warning for now.
> 
> Alternatively, we can just turn the damn thing into
> 	if (dev->mode == IMM_NIBBLE || dev->mode = IMM_PS2)
> 		ports = 3;
> 	else
> 		ports = 8;
> and be done with that...

Yes.
				Petr Vandrovec


  reply	other threads:[~2004-02-06 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-06 11:22 John Cherry
2004-02-06 11:33 ` viro
2004-02-06 16:52   ` Linus Torvalds
2004-02-06 18:22     ` viro
2004-02-06 18:35       ` Petr Vandrovec [this message]
2004-02-06 18:42       ` Linus Torvalds
2004-02-06 18:47         ` viro
2004-02-06 19:09           ` viro
2004-02-10 13:32         ` Dick Streefland
2004-02-10 15:44           ` Randy.Dunlap
2004-02-08  1:00 Jon Foster
2004-02-08  5:45 ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040206183508.GA3268@vana.vc.cvut.cz \
    --to=vandrove@vc.cvut.cz \
    --cc=cherry@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®