From: Andrew Morton <akpm@osdl.org>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: BUG: 2.6.2-mm1: destroy_workqueue
Date: Sat, 7 Feb 2004 08:32:54 -0800 [thread overview]
Message-ID: <20040207083254.2440175b.akpm@osdl.org> (raw)
In-Reply-To: <pan.2004.02.07.11.49.04.872088@smurf.noris.de>
Matthias Urlichs <smurf@smurf.noris.de> wrote:
>
> I had a crash when unmounting a reiserfs at shutdown time.
>
> Apparently, destroy_workqueue() inlines list_del(), which checks for
>
> 148 BUG_ON(entry->prev->next != entry);
>
> This is a problem when entry->prev is NULL. :-/
>
> Call trace, copied off the screen by hand:
> destroy_workqueue+0x30
> do_journal_release+0x4e
> journal_mark_dirty+0x18c
> journal_release+0x10
> reiserfs_put_super+0x24
>
yup, thanks.
--- 25/kernel/workqueue.c~cpuhotplug-03-core-workqueue-fix Fri Feb 6 14:36:04 2004
+++ 25-akpm/kernel/workqueue.c Fri Feb 6 14:36:41 2004
@@ -335,7 +335,7 @@ void destroy_workqueue(struct workqueue_
if (cpu_online(cpu))
cleanup_workqueue_thread(wq, cpu);
}
- list_del(&wq->list);
+ del_workqueue(wq);
unlock_cpu_hotplug();
kfree(wq);
}
_
prev parent reply other threads:[~2004-02-07 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-07 11:49 Matthias Urlichs
2004-02-07 16:32 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040207083254.2440175b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®