mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Valdis.Kletnieks@vt.edu
Cc: jmorris@redhat.com, linux-kernel@vger.kernel.org, sds@epoch.ncsc.mil
Subject: Re: 2.6.2-mm1, selinux, and initrd
Date: Sat, 7 Feb 2004 17:31:02 -0800	[thread overview]
Message-ID: <20040207173102.07b0e932.akpm@osdl.org> (raw)
In-Reply-To: <200402080115.i181Fn9q002138@turing-police.cc.vt.edu>

Valdis.Kletnieks@vt.edu wrote:
>
> On Sat, 07 Feb 2004 08:49:28 EST, James Morris said:
> 
> > Ok, looks like a problem where devfs is passing an empty string to 
> > do_mount when it expects a page.
> > 
> > Please try the patch below against 2.6.2-mm1.
> 
> OK, thanks.. that's a "confirmed working"...
> 


So I queue up the below patch, yes?



From: James Morris <jmorris@redhat.com>

devfs is passing an empty string to do_mount when it expects a page.



---

 fs/devfs/base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/devfs/base.c~devfs-do_mount-fix fs/devfs/base.c
--- 25/fs/devfs/base.c~devfs-do_mount-fix	2004-02-07 07:37:51.000000000 -0800
+++ 25-akpm/fs/devfs/base.c	2004-02-07 07:37:51.000000000 -0800
@@ -2840,7 +2840,7 @@ void __init mount_devfs_fs (void)
     int err;
 
     if ( !(boot_options & OPTION_MOUNT) ) return;
-    err = do_mount ("none", "/dev", "devfs", 0, "");
+    err = do_mount ("none", "/dev", "devfs", 0, NULL);
     if (err == 0) printk (KERN_INFO "Mounted devfs on /dev\n");
     else PRINTK ("(): unable to mount devfs, err: %d\n", err);
 }   /*  End Function mount_devfs_fs  */

_


  reply	other threads:[~2004-02-08  1:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-06  2:28 Valdis.Kletnieks
2004-02-06  5:02 ` James Morris
2004-02-06  5:13 ` James Morris
2004-02-07  3:39 ` James Morris
2004-02-07  5:05   ` Valdis.Kletnieks
2004-02-07 13:49     ` James Morris
2004-02-08  1:15       ` Valdis.Kletnieks
2004-02-08  1:31         ` Andrew Morton [this message]
2004-02-08  1:53           ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040207173102.07b0e932.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=jmorris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@epoch.ncsc.mil \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®