From: Andrew Morton <akpm@osdl.org>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Oopses on usbnet unload in 2.6.3-rc1
Date: Sun, 8 Feb 2004 00:14:24 -0800 [thread overview]
Message-ID: <20040208001424.77dac13e.akpm@osdl.org> (raw)
In-Reply-To: <20040208022921.GA1337@buk.vc.cvut.cz>
Petr Vandrovec <vandrove@vc.cvut.cz> wrote:
>
> recent thread about buggy sysfs fbdev support reminded me that situation
> with modules unloading is not quite correct... Besides floppy & nbd unload
> crashes (I already reported floppy/sysfs problem during Christmas),
Could you please rereport the floppy and nbd problems?
> there
> is a doublefree in usbnet's unload. I have no idea what's correct fix, but
> given fbdev's problems probably just removing kfree(dev->net).
usbnet has relevant changes in Jeff's tree (and hence in -mm).
diff -Nru a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c
--- a/drivers/usb/net/usbnet.c Sat Feb 7 17:16:08 2004
+++ b/drivers/usb/net/usbnet.c Sat Feb 7 17:16:08 2004
@@ -2933,7 +2933,7 @@
if (dev->driver_info->unbind)
dev->driver_info->unbind (dev, intf);
- kfree(dev->net);
+ free_netdev(dev->net);
kfree (dev);
usb_put_dev (xdev);
}
@@ -3061,7 +3061,7 @@
if (info->unbind)
info->unbind (dev, udev);
out2:
- kfree(net);
+ free_netdev(net);
out1:
kfree(dev);
out:
prev parent reply other threads:[~2004-02-08 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-08 2:29 Petr Vandrovec
2004-02-08 8:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040208001424.77dac13e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®