Re: [PATCH 405] Amiga Hydra Ethernet new driver model

[Adrian Bunk <bunk@fs.tum.de>]

On Sun, Feb 08, 2004 at 04:28:29PM +0100, Geert Uytterhoeven wrote:
> Hydra Ethernet: Convert to the new driver model
> 
> --- linux-2.6.3-rc1/drivers/net/hydra.c	2004-02-08 10:19:34.000000000 +0100
> +++ linux-m68k-2.6.3-rc1/drivers/net/hydra.c	2004-02-08 11:47:55.000000000 +0100
>...
> -static int __init hydra_init(unsigned long board);
> +static int __devinit hydra_init_one(struct zorro_dev *z,
> +				    const struct zorro_device_id *ent);
> +static int __init hydra_init(struct zorro_dev *z);
>...
> +static int __devinit hydra_init_one(struct zorro_dev *z,
> +				    const struct zorro_device_id *ent)
> +{
> +    int err;
>  
> -    return err;
> +    if (!request_mem_region(z->resource.start, 0x10000, "Hydra"))
> +	return -EBUSY;
> +    if ((err = hydra_init(z))) {
> +	release_mem_region(z->resource.start, 0x10000);
> +	return -EBUSY;
> +    }
> +    return 0;
>  }
>...

__init hydra_init called from __devinit hydra_init_one ?

This will break when compiling the driver statically into a kernel with
CONFIG_HOTPLUG=y .


> Gr{oetje,eeting}s,
> 
> 						Geert

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed