mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Olaf Hering <olh@suse.de>
Cc: linux-kernel@vger.kernel.org, jejb <james.bottomley@steeleye.com>,
	gibbs@scsiguy.com
Subject: Re: 2.6.3 CONFIG_SCSI_AIC7 X X X Kconfig bug
Date: Mon, 9 Feb 2004 08:58:17 -0800	[thread overview]
Message-ID: <20040209085817.055e1419.rddunlap@osdl.org> (raw)
In-Reply-To: <20040207162054.GA25651@suse.de>

On Sat, 7 Feb 2004 17:20:54 +0100 Olaf Hering <olh@suse.de> wrote:

| 
| who made that 'XXX in subject' reject? That is bug one.

Yeah, I just use xyz instead...


| another bug:
| 
| scsi is a module, but aic7xxx doesnt get build because it is set to yes.
| plain 2.6.3-rc1, happend also with 2.6.2.
| 
| grep SCSI .config | grep =
| CONFIG_BLK_DEV_IDESCSI=m
| CONFIG_SCSI=m
| CONFIG_SCSI_MULTI_LUN=y
| CONFIG_SCSI_REPORT_LUNS=y
| CONFIG_SCSI_CONSTANTS=y
| CONFIG_SCSI_LOGGING=y
| CONFIG_SCSI_AIC7XXX=y
| CONFIG_SCSI_QLA2XXX_CONFIG=m
| CONFIG_SCSI_DEBUG=m
| CONFIG_USB_HPUSBSCSI=m
| 
| I can not set CONFIG_SCSI_DEBUG to y, this is handled correctly.

Missing SCSI in "depends".  Patch is below.

--
~Randy



product_versions: linux-262-pv
description:	make Adaptec AIC7xyx drivers depend on SCSI tristate

diffstat:=
 drivers/scsi/aic7xxx/Kconfig.aic79xx |    2 +-
 drivers/scsi/aic7xxx/Kconfig.aic7xxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./drivers/scsi/aic7xxx/Kconfig.aic7xxx~depends ./drivers/scsi/aic7xxx/Kconfig.aic7xxx
--- ./drivers/scsi/aic7xxx/Kconfig.aic7xxx~depends	2004-02-03 19:43:42.000000000 -0800
+++ ./drivers/scsi/aic7xxx/Kconfig.aic7xxx	2004-02-09 09:04:01.000000000 -0800
@@ -4,7 +4,7 @@
 #
 config SCSI_AIC7XXX
 	tristate "Adaptec AIC7xxx Fast -> U160 support (New Driver)"
-	depends on PCI || EISA
+	depends on (PCI || EISA) && SCSI
 	---help---
 	This driver supports all of Adaptec's Fast through Ultra 160 PCI
 	based SCSI controllers as well as the aic7770 based EISA and VLB
diff -Naurp ./drivers/scsi/aic7xxx/Kconfig.aic79xx~depends ./drivers/scsi/aic7xxx/Kconfig.aic79xx
--- ./drivers/scsi/aic7xxx/Kconfig.aic79xx~depends	2004-02-03 19:43:43.000000000 -0800
+++ ./drivers/scsi/aic7xxx/Kconfig.aic79xx	2004-02-09 09:03:52.000000000 -0800
@@ -4,7 +4,7 @@
 #
 config SCSI_AIC79XX
 	tristate "Adaptec AIC79xx U320 support"
-	depends on PCI
+	depends on PCI && SCSI
 	help
 	This driver supports all of Adaptec's Ultra 320 PCI-X
 	based SCSI controllers.

  reply	other threads:[~2004-02-09 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-07 16:20 Olaf Hering
2004-02-09 16:58 ` Randy.Dunlap [this message]
2004-03-08 22:08   ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040209085817.055e1419.rddunlap@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=gibbs@scsiguy.com \
    --cc=james.bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®